fix(sessions): periodically cleanup expired sessions #1939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eusebiu-constantin-petu-dbk
requested review from
rchincha and
andaaron
as code owners
|
Let's evaluate if we need to JWTs so that we don't need to maintain state on server-side. |
Signed-off-by: Petu Eusebiu <[email protected]>
eusebiu-constantin-petu-dbk
dismissed stale reviews from rchincha and andaaron
via
ff6e6dd
eusebiu-constantin-petu-dbk
force-pushed
the
rm_sessions
branch
from
865194d to
ff6e6dd
Compare
andaaron
approved these changes
Oct 16, 2023
Codecov Report
@@ Coverage Diff @@
## main #1939 +/- ##
==========================================
- Coverage 91.93% 91.83% -0.11%
==========================================
Files 154 155 +1
Lines 26584 26667 +83
==========================================
+ Hits 24441 24490 +49
- Misses 1584 1611 +27
- Partials 559 566 +7
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Tests are failing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.